Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add workaround for vitest to run unit tests again #245

Merged
merged 2 commits into from
Aug 2, 2022
Merged

fix: add workaround for vitest to run unit tests again #245

merged 2 commits into from
Aug 2, 2022

Conversation

vroske-ld
Copy link
Contributor

Summary

The unit tests started breaking in this commit: 1a9695f

A github issue exists in vitest where they describe a workaround for the time being: vitest-dev/vitest#1753

@vroske-ld vroske-ld requested a review from a team August 2, 2022 22:43
@changeset-bot
Copy link

changeset-bot bot commented Aug 2, 2022 •
edited
Loading

⚠️ No Changeset found

Latest commit: 5b0ef5e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

chasedarkly
chasedarkly approved these changes Aug 2, 2022
View reviewed changes
Copy link
Contributor

@chasedarkly chasedarkly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we get a comment on this as well linking back to the issue and mentioning that we should check back for removal?

@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2022 •
edited
Loading

Size Change: 0 B

Total Size: 90 kB

ℹ️ View Unchanged
Filename Size
packages/alert/dist/index.es.js 1.27 kB
packages/alert/dist/index.js 1.8 kB
packages/avatar/dist/index.es.js 816 B
packages/avatar/dist/index.js 1.3 kB
packages/banner/dist/index.es.js 518 B
packages/banner/dist/index.js 1.03 kB
packages/button/dist/index.es.js 1.42 kB
packages/button/dist/index.js 1.95 kB
packages/clipboard/dist/index.es.js 1.16 kB
packages/clipboard/dist/index.js 1.69 kB
packages/core/dist/index.es.js 288 B
packages/core/dist/index.js 788 B
packages/counter/dist/index.es.js 275 B
packages/counter/dist/index.js 785 B
packages/dropdown/dist/index.es.js 1.27 kB
packages/dropdown/dist/index.js 1.78 kB
packages/form/dist/index.es.js 2.92 kB
packages/form/dist/index.js 3.59 kB
packages/icons/dist/index.es.js 2.33 kB
packages/icons/dist/index.js 2.92 kB
packages/lozenge/dist/index.es.js 692 B
packages/lozenge/dist/index.js 1.21 kB
packages/markdown/dist/index.es.js 871 B
packages/markdown/dist/index.js 1.36 kB
packages/menu/dist/index.es.js 3.62 kB
packages/menu/dist/index.js 4.21 kB
packages/modal/dist/index.es.js 1.86 kB
packages/modal/dist/index.js 2.46 kB
packages/navigation/dist/index.es.js 2.46 kB
packages/navigation/dist/index.js 3 kB
packages/notification/dist/index.es.js 1.65 kB
packages/notification/dist/index.js 2.17 kB
packages/overlay/dist/index.es.js 1.02 kB
packages/overlay/dist/index.js 1.5 kB
packages/pagination/dist/index.es.js 1.08 kB
packages/pagination/dist/index.js 1.58 kB
packages/popover/dist/index.es.js 2.93 kB
packages/popover/dist/index.js 3.43 kB
packages/progress-bubbles/dist/index.es.js 1.38 kB
packages/progress-bubbles/dist/index.js 1.86 kB
packages/progress/dist/index.es.js 1.06 kB
packages/progress/dist/index.js 1.6 kB
packages/slider/dist/index.es.js 462 B
packages/slider/dist/index.js 971 B
packages/split-button/dist/index.es.js 783 B
packages/split-button/dist/index.js 1.31 kB
packages/tab-list/dist/index.es.js 659 B
packages/tab-list/dist/index.js 1.17 kB
packages/table/dist/index.es.js 1.03 kB
packages/table/dist/index.js 1.61 kB
packages/toggle/dist/index.es.js 659 B
packages/toggle/dist/index.js 1.18 kB
packages/tokens/dist/index.es.js 1.34 kB
packages/tokens/dist/index.js 4.49 kB
packages/tooltip/dist/index.es.js 448 B
packages/tooltip/dist/index.js 965 B

compressed-size-action

@vroske-ld vroske-ld merged commit 138f291 into main Aug 2, 2022
@vroske-ld vroske-ld deleted the fix-tests branch August 2, 2022 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chasedarkly chasedarkly chasedarkly approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vroske-ld @chasedarkly